Prevent Fable 3 to hang if called from .NET 7 #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improve the situation when trying to use Fable 3 with .NET 7 #3294
This PR doesn't add support for .NET 7 because, I was not able to complete it (Failed attempt in #3363). Instead, it detect the version of
dotnetused to call Fable and if it is higher than 6, it will stop Fable and report a detailed error to guide the user.The error message contains the following information:
global.jsonto stay on Fable 3 (avoid upgrading to Feliz 2 etc.) and suggest a location for theglobal.jsonbased on the command invocation location.Preview:
Having such an improvement is important for templates or blog post / getting started. Indeed, upgrading to a major version for templates can takes some times and having the new user experience a process hang is not a good experience.
At least, with this error message people will be able to understand the situation and also not wait for a process which is blocked.
@alfonsogarciacaro You can merge the PR no problem but please don't release it yet. I want to have a look at #3441 too. My goal is to have a maintenance release of Fable 3 to make transition easier for users. I would have liked to do it sooner but better late than never 😇